Replace Boston dataset from examples and tests. by desilinguist · Pull Request #717 · EducationalTestingService/skll
Navigation Menu
{{ message }}
EducationalTestingService / skll Public
- Notifications You must be signed in to change notification settings
- Fork 67
Merged
Replace Boston dataset from examples and tests. #717
desilinguist merged 3 commits intomainfrom
Replace Boston dataset from examples and tests. #717
desilinguist merged 3 commits intomainfrom
Conversation
Copy link
Collaborator
desilinguist
commented
Sep 9, 2022
desilinguist
commented
This PR closes #700.
Replace boston dataset with california dataset everywhere.
- Remove boston example and replace with new california example.
- Remove
make_boston_example_data.pyscript and addmake_california_example_data.pyscript instead and sub-sample the full dataset is huge. - Remove references to boston dataset from everywhere.
- Remove boston example test data and add california example test data.
- Replace boston name in sample test data.
desilinguist added 3 commits
September 8, 2022 16:53- Remove boston example and replace with new california example. - Remove `make_boston_example_data.py` script and add `make_california_example_data.py` script instead and sub-sample since the full dataset is huge. - Remove references to boston dataset from everywhere. - Remove boston example test data and add california example test data.
desilinguist
requested review from
Frost45 and
mulhod
Copy link
Codecov Report
Base: 96.90% // Head: 96.90% // No change to project coverage 👍
Coverage data is based on head (
8f5b6f7) compared to base (c49147b).
Patch coverage: 22.22% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@ ## main #717 +/- ## ======================================= Coverage 96.90% 96.90% ======================================= Files 63 63 Lines 9271 9271 ======================================= Hits 8984 8984 Misses 287 287
| Impacted Files | Coverage Δ | |
|---|---|---|
| examples/make_california_example_data.py | 0.00% <0.00%> (ø) |
|
| skll/experiments/output.py | 97.38% <ø> (ø) |
|
| tests/test_regression.py | 99.64% <ø> (ø) |
|
| tests/test_examples.py | 98.36% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
mulhod approved these changes Sep 9, 2022
doc/run_experiment.rst
Show resolved
Hide resolved
doc/run_experiment.rst Show resolved Hide resolved
Frost45 approved these changes Sep 12, 2022
examples/make_california_example_data.py
Show resolved
Hide resolved
examples/make_california_example_data.py Show resolved Hide resolved
desilinguist
merged commit
bdf6107
into
main
delete-merged-branch
bot
deleted the
700-replace-boston-dataset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment