Home Original page

Infrastructure for logging to wandb by tamarl08 · Pull Request #758 · EducationalTestingService/skll

Conversation

@tamarl08

This PR adds initial infrastructure for W&B logging, including a configuration field to enable W&B, a wand interface class, documentation and tests.

@pep8speaks

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ac783c) 95.30% compared to head (78541a1) 95.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   95.30%   95.33%   +0.02%     
==========================================
  Files          29       30       +1     
  Lines        3580     3598      +18     
==========================================
+ Hits         3412     3430      +18     
  Misses        168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

desilinguist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the coverage checks are not being met?

Tamar Lavee added 2 commits

December 7, 2023 15:46

@tamarl08

Is there a reason the coverage checks are not being met?

I added a test for run_configuration with W&B and now it's covered. I don't know why it did not count as covered before, those lines are tested at test_wandb.py

desilinguist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the new test!

mulhod