fix: getnewaddress - don't blind bech32 addresses by delta1 · Pull Request #1246 · ElementsProject/elements
fixes #1245 - getnewaddress will now return an unblinded bech32 address even when -blindedaddresses=1 in config
059a4a6 looks fine to me.
Locally the following tests fail
elements-059a4a> feature_confidential_transactions.py | ✖ Failed | 1 s
elements-059a4a> feature_sighash_rangeproof.py | ✖ Failed | 2 s
elements-059a4a> rpc_signrawtransaction.py --legacy-wallet | ✖ Failed | 6 s
These look like real failures; they happen consistently.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm a bit concerned that this change will break existing workflows of people by unblinding their addresses on thm.
I think the old behavior was at least inconsistent, so I'm fine with a comment added to the release notes and this fix making things consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters