Fix position of version argument in walletcreatefundedpsbt by tomt1664 · Pull Request #1474 · ElementsProject/elements

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tomt1664

Copy link

Member

@tomt1664 tomt1664 commented

Jul 9, 2025

Correct typecheck and position of psbt_version in walletcreatefundedpsbt RPC.
Also added full list of arguments to a functional test case to check input format.

@tomt1664 tomt1664 requested a review from delta1

July 9, 2025 14:59

@tomt1664 tomt1664 force-pushed the fix/duplicate_solve_data branch from ddeb580 to 9c6415d Compare

July 9, 2025 15:34

@tomt1664 tomt1664 requested a review from delta1

July 10, 2025 13:59
Copy link

Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 90947cb

tested locally

@delta1 delta1 merged commit c4bc9fd into ElementsProject:master

Jul 11, 2025

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delta1 delta1 delta1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomt1664 @delta1