Fix position of version argument in walletcreatefundedpsbt by tomt1664 · Pull Request #1474 · ElementsProject/elements
Navigation Menu
{{ message }}
ElementsProject / elements Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
delta1 merged 2 commits intoElementsProject:masterfrom
Jul 11, 2025Merged
Fix position of version argument in walletcreatefundedpsbt#1474
delta1 merged 2 commits intoElementsProject:masterfrom
Fix position of version argument in walletcreatefundedpsbt#1474
delta1 merged 2 commits intoElementsProject:masterfrom
Conversation
Copy link
Member
tomt1664
commented
Jul 9, 2025
tomt1664
commented
Correct typecheck and position of psbt_version in walletcreatefundedpsbt RPC.
Also added full list of arguments to a functional test case to check input format.
tomt1664
requested a review
from delta1
tomt1664
force-pushed
the
fix/duplicate_solve_data
branch
from
ddeb580 to
9c6415d
Compare
delta1 reviewed Jul 10, 2025
test/functional/rpc_psbt.py
Outdated
Show resolved
Hide resolved
test/functional/rpc_psbt.py Outdated Show resolved Hide resolved
tomt1664
requested a review
from delta1
delta1 approved these changes Jul 11, 2025
Copy link
Member
delta1
left a comment
delta1
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 90947cb
tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment