suggestions for updates to itemgraph guide by jyaistMap · Pull Request #2312 · Esri/arcgis-python-api
- some suggested edits, like adding an Introduction, small grammatical stuff, bullet points in one place, and hyperlinks
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
jyaistMap
changed the title
Jy rvw graph guides
suggestions for updates to itemgraph guide
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On board with all of the wording changes, but clicking all of those hyperlinks you added lead me to 404 github pages- I'm a bit confused by that, especially the ones that just go github.com/python. Is that intentional? Will that be smoothed over during the build later?
hey @nparavicini7 - The best format for hyperlinks according to the Dev Website team is to use relative paths as I did with those. They don't properly work in a local environment, but through the Gatsby application they do. Going from guide to guide is one format; going from guide to sample is another. It is a bit confusing - but those formats work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters