Updating URL, the old one returned 404 by szabgab · Pull Request #1196 · GalSim-developers/GalSim
Navigation Menu
{{ message }}
GalSim-developers / GalSim Public
- Notifications You must be signed in to change notification settings
- Fork 118
Merged
Updating URL, the old one returned 404#1196
rmjarvis merged 1 commit intoGalSim-developers:releases/2.4from
szabgab:patch-1
Updating URL, the old one returned 404#1196
rmjarvis merged 1 commit intoGalSim-developers:releases/2.4from
szabgab:patch-1
Conversation
Copy link
Contributor Author
szabgab
commented
Dec 4, 2022
szabgab commented
Dec 4, 2022I sent this PR as part of my Daily CI project. I wrote about here: https://dev.to/szabgab/day-4-github-actions-for-columbian-spanish-kop
Copy link
Member
rmjarvis
commented
Dec 4, 2022
rmjarvis commented
Dec 4, 2022Thanks Gabor! That's a mistake that it seems no one noticed before. Thanks for fixing it!
rmjarvis approved these changes Dec 4, 2022
rmjarvis
added this to the
v2.5 milestone
Copy link
Contributor Author
szabgab
commented
Dec 4, 2022
szabgab commented
Dec 4, 2022Yeah, I run a project called https://pydigger.com/ where I collect information about Python packages. Partially to find one that have a link to GitHub in their meta data, but don't have CI configured yet. This project came up as a false positive as there was a link but there was no CI behind it. It should have reported that the link is incorrect.
rmandelb approved these changes Dec 4, 2022
rmjarvis
merged commit
fbe2807
into
GalSim-developers:releases/2.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment