fix: shade com.alibaba.* by Nizernizer · Pull Request #534 · HXSecurity/DongTai-agent-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Nizernizer

Copy link Copy Markdown

Contributor

No description provided.

@Nizernizer Nizernizer requested a review from lostsnow

June 12, 2023 07:38

@lostsnow

Copy link Copy Markdown

Member

fix #533

@lostsnow lostsnow merged commit e7ffdf3 into HXSecurity:beta

Jun 12, 2023
}
try {
loader.loadClass("com.alibaba.dubbo.monitor.support.MonitorFilter");
loader.loadClass(" com.alibaba.dubbo.monitor.support.MonitorFilter".substring(1));
Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the same class is being loaded here. What is the benefit of writing it this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lostsnow lostsnow lostsnow approved these changes

+1 more reviewer

@risuxx risuxx risuxx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nizernizer @lostsnow @risuxx