Support: `Explicit defaults` & `Using` on `Join` & the inner table in a left or right outer join can also be used in an inner join by KKould · Pull Request #146 · KipData/KiteSQL

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@KKould

Copy link Copy Markdown

Member

@KKould KKould commented

Feb 21, 2024

What problem does this PR solve?

features:

  • Explicit defaults
    • Insert into t1 values(0, Default);
  • Using on Join
    • select * from t1 left join t2 using (id);
  • the inner table in a left or right outer join can also be used in an inner join
    • select * from t1 inner join t1 as t2 on t1.a = t2.a

fix:

  • fixed when subquery on select, the table of column is temp.
select ( select a from t1 ) from t1;

+--------------------+
| t1.a               |
+====================+
| 1                  |
+--------------------+
  • fixed when selecting * from multiple tables to join, the output fields are random by table.
    • select * from t1 inner join t2 on t1.id = t2.id

Issue link: #130

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added bug

Something isn't working

enhancement

New feature or request

labels

Feb 21, 2024

@KKould KKould self-assigned this

Feb 21, 2024

@KKould KKould mentioned this pull request

Feb 21, 2024

48 tasks

@KKould KKould merged commit e8fc5cd into KipData:main

Feb 21, 2024

@KKould KKould modified the milestone: SQL 2016

Feb 21, 2024

@KKould KKould added this to the SQL 2016 milestone

Jul 26, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KKould KKould

Labels

bug

Something isn't working

enhancement

New feature or request

Projects

None yet

Milestone

SQL 2016

Development

Successfully merging this pull request may close these issues.

1 participant

@KKould