Support: `Explicit defaults` & `Using` on `Join` & the inner table in a left or right outer join can also be used in an inner join by KKould · Pull Request #146 · KipData/KiteSQL
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 54
Conversation
Copy link Copy Markdown
Member
KKould
commented
Feb 21, 2024
KKould
commented
What problem does this PR solve?
features:
Explicit defaultsInsert into t1 values(0, Default);
UsingonJoinselect * from t1 left join t2 using (id);
- the inner table in a left or right outer join can also be used in an inner join
select * from t1 inner join t1 as t2 on t1.a = t2.a
fix:
- fixed when subquery on select, the table of column is temp.
select ( select a from t1 ) from t1; +--------------------+ | t1.a | +====================+ | 1 | +--------------------+
- fixed when selecting * from multiple tables to join, the output fields are random by table.
select * from t1 inner join t2 on t1.id = t2.id
Issue link: #130
Code changes
- Has Rust code change
- Has CI related scripts change
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Side effects
- Performance regression: Consumes more CPU
- Performance regression: Consumes more Memory
- Breaking backward compatibility
Note for reviewer
KKould added 2 commits
February 21, 2024 15:08…outer join can also be used in an inner join
KKould
self-assigned this
KKould
merged commit
e8fc5cd
into
KipData:main
KKould
modified the milestone:
SQL 2016
KKould
added this to the
SQL 2016 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment