feat: add function Lower & Upper by wszhdshys · Pull Request #231 · KipData/KiteSQL
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 54
Merged
KKould merged 2 commits intoKipData:mainfrom
Oct 19, 2024Merged
feat: add function Lower & Upper#231
KKould merged 2 commits intoKipData:mainfrom
feat: add function Lower & Upper#231
KKould merged 2 commits intoKipData:mainfrom
Conversation
Copy link Copy Markdown
Contributor
What problem does this PR solve?
Add functions Lower & Upper
Code changes
- Has Rust code change
- Has CI related scripts change
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Side effects
- Performance regression: Consumes more CPU
- Performance regression: Consumes more Memory
- Breaking backward compatibility
Note for reviewer
NANASE added 2 commits
October 20, 2024 02:56
KKould
self-requested a review
KKould
assigned
KKould and
wszhdshys and unassigned
KKould
KKould approved these changes Oct 19, 2024
Copy link Copy Markdown
Member
KKould
left a comment
KKould
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution.
KKould
merged commit
66feb7c
into
KipData:main
KKould
added this to the
SQL 2016 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment