fixing detections afterTrack logic by BryonLewis · Pull Request #1273 · Kitware/dive

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@BryonLewis

Copy link Copy Markdown

Collaborator

@BryonLewis BryonLewis commented

Jul 15, 2022

edited

Loading

Closes #1272

Issue was caused by using getAnyTrack with a trackId that doesn't exists.
Original intention was that this was being used for creating a track in another camera where the original track already had a trackId. This code was just grabbing the type of the source camera track to make sure they aligned.
The newTracksettingsAfterLogic when the user is in Continuous detection mode uses a new overrideId by grabbing a new trackId to assign to the new Track. When in singlecam the new trackId doesn't exist already so you get the error. Swapping this to getAnyPossibleTrack will return an undefined if it is not located and will revert back to the default track type instead of trying to match it up.

ContinuousSmall.mp4

@BryonLewis BryonLewis marked this pull request as ready for review

July 15, 2022 15:28

@BryonLewis BryonLewis requested review from marySalvi and waxlamp

July 15, 2022 15:43
Copy link Copy Markdown

Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, error no longer appears in single camera continuous detection mode

@BryonLewis BryonLewis merged commit 58b7b6d into main

Jul 18, 2022

@BryonLewis BryonLewis deleted the fix-continous-detection branch

July 18, 2022 12:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marySalvi marySalvi marySalvi approved these changes

@waxlamp waxlamp Awaiting requested review from waxlamp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Continuous Creation: TrackId not found in any camera

2 participants

@BryonLewis @marySalvi