fixing detections afterTrack logic by BryonLewis · Pull Request #1273 · Kitware/dive
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
fixing detections afterTrack logic#1273
BryonLewis merged 1 commit intomainfrom
fixing detections afterTrack logic#1273
BryonLewis merged 1 commit intomainfrom
Conversation
Copy link Copy Markdown
Collaborator
Closes #1272
Issue was caused by using getAnyTrack with a trackId that doesn't exists.
Original intention was that this was being used for creating a track in another camera where the original track already had a trackId. This code was just grabbing the type of the source camera track to make sure they aligned.
The newTracksettingsAfterLogic when the user is in Continuous detection mode uses a new overrideId by grabbing a new trackId to assign to the new Track. When in singlecam the new trackId doesn't exist already so you get the error. Swapping this to getAnyPossibleTrack will return an undefined if it is not located and will revert back to the default track type instead of trying to match it up.
ContinuousSmall.mp4
BryonLewis
marked this pull request as ready for review
BryonLewis
requested review from
marySalvi and
waxlamp
marySalvi approved these changes Jul 15, 2022
Copy link Copy Markdown
Collaborator
marySalvi
left a comment
marySalvi
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, error no longer appears in single camera continuous detection mode
BryonLewis
merged commit
58b7b6d
into
main
BryonLewis
deleted the
fix-continous-detection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment