Head Tail Bbox Updating by BryonLewis · Pull Request #1345 · Kitware/dive

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@BryonLewis

Copy link Copy Markdown

Collaborator

@BryonLewis BryonLewis commented

Apr 11, 2023

edited

Loading

resolves #1168

Changes the head/tail logic for expanding bounds:

  • If it is a new track that doesn't have a bbox yet it will use the standard padding
  • If it is an existing track and the points are moved inside of the bounds there is no adjustment to the bounding box.
  • If the points move outside of an existing bounds it will adjust to the new points with ZERO padding.

@BryonLewis BryonLewis marked this pull request as ready for review

April 12, 2023 12:41

@BryonLewis BryonLewis requested a review from marySalvi

April 12, 2023 12:41
Copy link Copy Markdown

Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryonLewis BryonLewis merged commit d1eb6b2 into main

May 10, 2023

@BryonLewis BryonLewis deleted the head-tail-update branch

May 10, 2023 16:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marySalvi marySalvi marySalvi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If head tail points are made within a bounding box, do not adjust the bounding box size

2 participants

@BryonLewis @marySalvi