Polling Based Job Cancellation by BryonLewis · Pull Request #1365 · Kitware/dive
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
Conversation
Copy link Copy Markdown
Collaborator
BryonLewis
commented
Aug 10, 2023
BryonLewis
commented
The previous cancellation logic was dependent on the subprocess printing lines.
This update does a 1 minute polling interval where it checks to see if the state is cancelling.
If it is cancelling it will send signals to kill the sub process. For VIAME it seems that it only responds favorably to a SIGINT signal so that is added.
BryonLewis added 2 commits
August 10, 2023 15:32
BryonLewis
requested a review
from marySalvi
marySalvi approved these changes Aug 11, 2023
Copy link Copy Markdown
Collaborator
marySalvi
left a comment
marySalvi
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BryonLewis
merged commit
fc12337
into
main
BryonLewis
deleted the
job-cancellation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants