Added new methods in `MessagesLayoutDelegate` for adjusting alignment of message top and bottom labels by martinpucik · Pull Request #1671 · MessageKit/MessageKit
Navigation Menu
{{ message }}
MessageKit / MessageKit Public
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Merged
Added new methods in MessagesLayoutDelegate for adjusting alignment of message top and bottom labels #1671
martinpucik merged 6 commits intomasterfrom
Added new methods in MessagesLayoutDelegate for adjusting alignment of message top and bottom labels #1671
martinpucik merged 6 commits intomasterfrom
Conversation
Copy link
Contributor
martinpucik
commented
Feb 3, 2022
martinpucik
commented
What does this implement/fix? Explain your changes.
- Adds an option to use
MessagesLayoutDelegatemethods for adjusting message top/bottom label alignments without the need to subclass MessageSizeCalculators - Chat example not used files cleanup
Does this close any currently open issues?
N/A
martinpucik added 4 commits
January 22, 2022 12:05
martinpucik
added
the
enhancement
label
martinpucik
self-assigned this
…gnments CHangelog
martinpucik
removed their assignment
…gnments Fix example MessageKit local package import
Kaspik requested changes Feb 3, 2022
Copy link
Member
Kaspik
left a comment
Kaspik
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it will be small but could you please create super small V4 Migration info section into Readme file for people that upgrade from V3?
Copy link
Contributor Author
martinpucik
commented
Feb 3, 2022
martinpucik commented
Feb 3, 2022There are no breaking changes yet in 4.0. I'd add the migration doc when there is something to migrate 😁
Copy link
Member
Kaspik
commented
Feb 3, 2022
Kaspik commented
Feb 3, 2022Well you have to add new functions when upgrading to it, they are not optional, right? 😅
Copy link
Contributor Author
martinpucik
commented
Feb 4, 2022
martinpucik commented
Feb 4, 2022There are default implementations in MessagesLayoutDelegate extension so clients don't have to add them 🙌
Kaspik approved these changes Feb 8, 2022
martinpucik
merged commit
c2cf1a2
into
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment