Fix iOS 13 depraction, fix Swiftlint and Danger on PRs by Kaspik · Pull Request #1715 · MessageKit/MessageKit
Navigation Menu
{{ message }}
MessageKit / MessageKit Public
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Conversation
Copy link
Member
Kaspik
commented
May 10, 2022
Kaspik
commented
- add valid swiftlint config
- fix Danger and swiftlint on PRs
- fix iOS 13 showMenu depraction
Kaspik added 3 commits
May 10, 2022 16:46
Kaspik
requested a review
from martinpucik
Copy link
| 1 Warning | |
|---|---|
| ⚠️ | Sources/Controllers/MessagesViewController+Menu.swift#L71 - Force unwrapping should be avoided.force_unwrapping MessagesViewController+Menu.swift:71 |
Generated by 🚫 Danger
Kaspik
enabled auto-merge
martinpucik approved these changes May 10, 2022
Copy link
Contributor
martinpucik
left a comment
martinpucik
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Kaspik
merged commit
0f6b4c2
into
main
Kaspik
deleted the
swiftlint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants