Convert Extension to a string enum · Pull Request #16425 · microsoft/TypeScript

yuit

yuit approved these changes Jun 10, 2017

@ghost ghost deleted the extension branch

June 10, 2017 02:32

mhegazy added a commit that referenced this pull request

Jun 15, 2017

mhegazy added a commit that referenced this pull request

Jun 15, 2017
* Revert "Convert Extension to a string enum (#16425)"

This reverts commit 09321b3.

* Revert "Also convert ClassificationTypeNames and CommandTypes/CommandNames"

This reverts commit f94818d.

* Revert "Make ScriptElementKind and HighlightSpanKind string enums"

This reverts commit b162097.

* Revert "Make ScriptElementKind and HighlightSpanKind string enums"

This reverts commit b162097.

# Conflicts:
#	lib/lib.d.ts
#	lib/lib.es2016.full.d.ts
#	lib/lib.es2017.full.d.ts
#	lib/lib.es5.d.ts
#	lib/lib.es6.d.ts
#	lib/lib.esnext.full.d.ts
#	lib/tsc.js
#	lib/tsserver.js
#	lib/tsserverlibrary.d.ts
#	lib/tsserverlibrary.js
#	lib/typescript.d.ts
#	lib/typescript.js
#	lib/typescriptServices.d.ts
#	lib/typescriptServices.js
#	lib/typingsInstaller.js

* Update LKG

* Revert "Make CommandTypes a const enum and use `allCommandTypes` for unit test"

This reverts commit f6240cb.

@microsoft microsoft locked and limited conversation to collaborators

Jun 14, 2018

This pull request was closed.