Issue #6661: Moved content writing from Flush to new method FinalizeContent by h3allen · Pull Request #8266 · MonoGame/MonoGame
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3k
Merged
SimonDarksideJ merged 7 commits intoMonoGame:developfrom
Jun 30, 2025Merged
Issue #6661: Moved content writing from Flush to new method FinalizeContent#8266
SimonDarksideJ merged 7 commits intoMonoGame:developfrom
Issue #6661: Moved content writing from Flush to new method FinalizeContent#8266
SimonDarksideJ merged 7 commits intoMonoGame:developfrom
Conversation
Copy link
Contributor
h3allen
commented
Apr 2, 2024
h3allen
commented
Solution for Issue #6661
Moves the previous code writing content in Flush() to new method FinalizeContent() and calls it in ContentCompiler method Compile() before calling Flush().
Copy link
Contributor
ThomasFOG
commented
Apr 5, 2024
ThomasFOG commented
Apr 5, 2024Note for maintainers: tests must be run against this PR.
Peru-S reviewed Apr 5, 2024
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs
Outdated
Show resolved
Hide resolved
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs Outdated Show resolved Hide resolved
Copy link
Contributor
dellis1972
commented
Sep 26, 2024
dellis1972 commented
Sep 26, 2024@h3allen can you rebase this PR please so we can run unit tests?
dellis1972 reviewed Sep 26, 2024
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs
Outdated
Show resolved
Hide resolved
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs Outdated Show resolved Hide resolved
greembeems added 2 commits
October 26, 2024 14:40Flush called base.Flush() exclusively, no longer needed
h3allen
force-pushed
the
develop
branch
from
8ff0ab6 to
592a6cb
Compare
dellis1972 reviewed Oct 27, 2024
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs
Outdated
Show resolved
Hide resolved
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs Outdated Show resolved Hide resolved
SimonDarksideJ requested changes Mar 24, 2025
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs
Outdated
Show resolved
Hide resolved
MonoGame.Framework.Content.Pipeline/Serialization/Compiler/ContentWriter.cs Outdated Show resolved Hide resolved
Copy link
Contributor
SimonDarksideJ
commented
Jun 12, 2025
SimonDarksideJ commented
Jun 12, 2025Any chance of an update @h3allen ? If no response we will have to close.
Copy link
Contributor Author
h3allen
commented
Jun 12, 2025
h3allen commented
Jun 12, 2025Apologies for the delay. Yes, I'll get to updating it ASAP!
h3allen and others added 3 commits
June 17, 2025 13:14SimonDarksideJ approved these changes Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants