Removed superfluous override of WMS_VERSION by EmilSodergren · Pull Request #13 · NASAWorldWind/WorldWindJava
The parameter WMS_VERSION is already read from configuration and set in
the params varable. To overwrite it here will only make it impossible to
change by configuration.
The parameter WMS_VERSION is already read from configuration and set in the params varable. To overwrite it here will only make it impossible to change by configuration.
| setFallbacks(params); | ||
|
|
||
| // Setup WMS URL builder. | ||
| params.setValue(AVKey.WMS_VERSION, caps.getVersion()); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already done at line 130, IF the params does not contain a value already. This line just overwrites any WMS_VERSION that might be set in configuration.
pdavidc
modified the milestones:
v2.1.0,
v2.2.0
pdavidc pushed a commit that referenced this pull request
Dec 12, 2016Applies pull request #13 to the develop branch.
We've switched to a Git Flow branching model since this pull request was submitted. In the interest of getting this trivial change in to v2.1.0, we've manually applied this pull request to the develop branch. See commit 52afdee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters