dask: `Data.convolution_filter` by davidhassell · Pull Request #294 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
sadielbartholomew merged 3 commits intoNCAS-CMS:lama-to-daskfrom
Jan 11, 2022Merged
dask: Data.convolution_filter#294
sadielbartholomew merged 3 commits intoNCAS-CMS:lama-to-daskfrom
dask: Data.convolution_filter#294
sadielbartholomew merged 3 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
davidhassell added 2 commits
January 4, 2022 20:30
davidhassell
requested a review
from sadielbartholomew
Copy link Copy Markdown
Collaborator Author
davidhassell
commented
Jan 5, 2022
davidhassell commented
Jan 5, 2022Note: I changed the cfdm version to >= 1.9.0.1, as a convenience for my environment - I don't think that there are any knock-on effects from this ....
sadielbartholomew approved these changes Jan 11, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect: works, with updated testing, and is very thoroughly commented. Thanks!
Copy link Copy Markdown
Member
sadielbartholomew
commented
Jan 11, 2022
sadielbartholomew commented
Jan 11, 2022Note: I changed the cfdm version to >= 1.9.0.1, as a convenience for my environment - I don't think that there are any knock-on effects from this ....
No code-level effects though it does break the CI jobs because they are set to install the previous version specifically. Just to be rigorous I'll push a reversion of the version and re-trigger the CI jobs now. The test_Data module passes locally for me but it is always nice to check everything works across each environment as we go...
Copy link Copy Markdown
Member
sadielbartholomew
commented
Jan 11, 2022
sadielbartholomew commented
Jan 11, 2022Opening and closing to re-trigger to CI jobs...
sadielbartholomew
closed this
sadielbartholomew
reopened this
Copy link Copy Markdown
Member
sadielbartholomew
commented
Jan 11, 2022
sadielbartholomew commented
Jan 11, 2022Clean sweep of passes, so I'll merge now and update the grand table...
sadielbartholomew
merged commit
4c28c43
into
NCAS-CMS:lama-to-dask
sadielbartholomew
mentioned this pull request
davidhassell
deleted the
dask-convolution-filter
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment