dask: fix `Data.equals` for arbitrary chunk distributions by davidhassell · Pull Request #330 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
Mar 1, 2022Merged
dask: fix Data.equals for arbitrary chunk distributions#330
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
dask: fix Data.equals for arbitrary chunk distributions#330
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
Copy link Copy Markdown
Collaborator
davidhassell
commented
Feb 28, 2022
davidhassell
commented
Fix Data.equals for arbitrary chunk distributions.
davidhassell
requested a review
from sadielbartholomew
davidhassell
mentioned this pull request
sadielbartholomew approved these changes Feb 28, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple watertight fix and improved testing; excellent, thanks. Please merge.
cf/data/dask_utils.py
Outdated
Show resolved
Hide resolved
cf/data/dask_utils.py Outdated Show resolved Hide resolved
davidhassell
merged commit
b195c02
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-equals-fix
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment