dask: `Data` query interface by davidhassell · Pull Request #368 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 3 commits intoNCAS-CMS:lama-to-daskfrom
Apr 5, 2022Merged
dask: Data query interface#368
davidhassell merged 3 commits intoNCAS-CMS:lama-to-daskfrom
dask: Data query interface#368
davidhassell merged 3 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
Copy link Copy Markdown
Collaborator
davidhassell
commented
Mar 31, 2022
davidhassell
commented
Just deleting these methods, as they merely duplicate code in cf.Query (https://github.com/NCAS-CMS/cf-python/blob/v3.12.0/cf/query.py#L667-L710). That code is already as efficient as it can be for dask arrays.
davidhassell
requested a review
from sadielbartholomew
davidhassell
mentioned this pull request
sadielbartholomew approved these changes Apr 4, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
•
edited
Loading
sadielbartholomew
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just deleting these methods, as they merely duplicate code
Very sensible!
I do notice there are still such methods in mixin.propertiesdata but as long as that's known and/or OK, please merge!
Copy link Copy Markdown
Collaborator Author
davidhassell
commented
Apr 4, 2022
davidhassell commented
Apr 4, 2022I do notice there are still such methods in mixin.propertiesdata but as long as that's known and/or OK, please merge!
This was not known! These other methods can be scrapped to - I'll put in another commit that deletes them before merging.
davidhassell and others added 2 commits
April 5, 2022 08:55
davidhassell
merged commit
e11f739
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-query
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment