dask: `Data._set_subspace` by davidhassell · Pull Request #371 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 1 commit intoNCAS-CMS:lama-to-daskfrom
Apr 5, 2022Merged
davidhassell merged 1 commit intoNCAS-CMS:lama-to-daskfrom
davidhassell merged 1 commit intoNCAS-CMS:lama-to-daskfrom
Conversation
Copy link Copy Markdown
Collaborator
davidhassell
commented
Apr 4, 2022
davidhassell
commented
_set_subspace is no longer needed, as it's functionality has been replicated in __setitem__, and the slicing of chunks is now out of our control (i.e. dask deals with it)
davidhassell
requested a review
from sadielbartholomew
davidhassell
changed the title
_set_subspace
dask: Data._set_subspace
davidhassell
mentioned this pull request
sadielbartholomew approved these changes Apr 5, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A justified change. Please merge.
davidhassell
merged commit
0cd3197
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-set-subspace
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment