dask: `Data.compressed` by davidhassell · Pull Request #383 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 5 commits intoNCAS-CMS:lama-to-daskfrom
Apr 20, 2022Merged
davidhassell merged 5 commits intoNCAS-CMS:lama-to-daskfrom
davidhassell merged 5 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
davidhassell added 2 commits
March 31, 2022 16:09
davidhassell
requested a review
from sadielbartholomew
davidhassell
mentioned this pull request
sadielbartholomew approved these changes Apr 20, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
•
edited
Loading
sadielbartholomew
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent: an elegant dask solution with robust updates to the unit test. There's one test line that seems superfluous, but overall this is good to merge (once the conflicts are resolved).
cf/test/test_Data.py
Outdated
Show resolved
Hide resolved
cf/test/test_Data.py Outdated Show resolved Hide resolved
davidhassell and others added 3 commits
April 20, 2022 20:46Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
davidhassell
merged commit
cdea366
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-compressed
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment