dask: `Data.Units` by davidhassell · Pull Request #405 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 3 commits intoNCAS-CMS:lama-to-daskfrom
May 13, 2022Merged
dask: Data.Units#405
davidhassell merged 3 commits intoNCAS-CMS:lama-to-daskfrom
dask: Data.Units#405
davidhassell merged 3 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
Copy link Copy Markdown
Collaborator
davidhassell
commented
May 12, 2022
davidhassell
commented
Code reorganisation for consistency. Also new unit test.
davidhassell
requested a review
from sadielbartholomew
davidhassell
mentioned this pull request
sadielbartholomew approved these changes May 13, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. One very minor suggestion raised, but this is all good to merge so please go ahead when ready. Thanks.
cf/data/dask_utils.py
Outdated
Show resolved
Hide resolved
cf/data/dask_utils.py Outdated Show resolved Hide resolved
davidhassell
merged commit
632b396
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-Units
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment