dask: `Data.reconstruct_sectioned_data` by davidhassell · Pull Request #407 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
Jun 14, 2022Merged
dask: Data.reconstruct_sectioned_data#407
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
dask: Data.reconstruct_sectioned_data#407
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
Copy link Copy Markdown
Collaborator
davidhassell
commented
Jun 13, 2022
davidhassell
commented
This method was only ever used by Field.regrid[s|c], but will not be when those methods are daskified. Therefore I think that it is OK to deprecate it at this time.
davidhassell
requested a review
from sadielbartholomew
davidhassell
mentioned this pull request
sadielbartholomew approved these changes Jun 13, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question raised, but otherwise all good! Thanks.
cf/test/test_Data.py
Show resolved
Hide resolved
cf/test/test_Data.py Show resolved Hide resolved
davidhassell
merged commit
719fe86
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-reconstruct-sectioned-data
branch
davidhassell
added this to the
3.14.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment