dask: `Data.count`, `Data.count_masked` by davidhassell · Pull Request #414 · NCAS-CMS/cf-python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, please merge (after addressing the merge conflicts).
|
|
||
| def count(self): | ||
| @daskified(_DASKIFIED_VERBOSE) | ||
| def count(self, axis=None, keepdims=True, split_every=None): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to register (in an Issue or similar) this as an API change given these new parameters?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I'll add that to the table in #295, and we can make one mega issue with collating all of this type of change.
davidhassell
changed the title
dask:
dask: Data.countData.count, Data.count_masked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters