dask: Cached first, second and last data values by davidhassell · Pull Request #494 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 13 commits intoNCAS-CMS:lama-to-daskfrom
Nov 17, 2022Merged
dask: Cached first, second and last data values#494
davidhassell merged 13 commits intoNCAS-CMS:lama-to-daskfrom
dask: Cached first, second and last data values#494
davidhassell merged 13 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
davidhassell added 3 commits
November 10, 2022 18:33
davidhassell
requested a review
from sadielbartholomew
davidhassell
added this to the
3.14.0 milestone
davidhassell
removed
the
low priority
label
davidhassell added 4 commits
November 16, 2022 13:52
Copy link Copy Markdown
Collaborator Author
davidhassell
commented
Nov 16, 2022
davidhassell commented
Nov 16, 2022New changes done - ready for review. Thanks.
sadielbartholomew approved these changes Nov 17, 2022
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Achieves the intended feature as described in #493 (comment), with a neat implementation and sufficient testing. I've made one suggestion that may be taken or left (not a blocker). Please merge when ready!
cf/data/data.py
Outdated
Show resolved
Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py
Outdated
Show resolved
Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
cf/test/test_Data.py
Show resolved
Hide resolved
cf/test/test_Data.py Show resolved Hide resolved
davidhassell and others added 4 commits
November 17, 2022 10:02
davidhassell
merged commit
73950e1
into
NCAS-CMS:lama-to-dask
davidhassell
deleted the
dask-str
branch
davidhassell
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment