dask: `Data.get_filenames` (3) by davidhassell · Pull Request #498 · NCAS-CMS/cf-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@davidhassell

Copy link Copy Markdown

Collaborator

Fixes #454

Replaces, and is identical to, a previous PR (#490) which got accidentally deleted!

@davidhassell davidhassell added low priority dask

Relating to the use of Dask

labels

Nov 15, 2022

@davidhassell davidhassell mentioned this pull request

Nov 15, 2022

@davidhassell davidhassell added this to the 3.14.0 milestone

Nov 15, 2022

@davidhassell davidhassell changed the title dask: Data.get_filenames dask: Data.get_filenames (3)

Nov 22, 2022
Copy link Copy Markdown

Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, with really thorough example cases in the docstring and new test. Please merge!

davidhassell reacted with hooray emoji

@davidhassell davidhassell merged commit 47be288 into NCAS-CMS:lama-to-dask

Dec 6, 2022

@davidhassell davidhassell deleted the dask-get-filenames-3 branch

December 6, 2022 09:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

No one assigned

Labels

dask

Relating to the use of Dask

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhassell @sadielbartholomew