LAMA to Dask: trivial fixes for passing `test_{decorators, style}` by sadielbartholomew · Pull Request #503 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
sadielbartholomew merged 2 commits intoNCAS-CMS:lama-to-daskfrom
Nov 22, 2022Conversation
Copy link Copy Markdown
Member
sadielbartholomew
commented
Nov 22, 2022
sadielbartholomew
commented
Address two test module items towards the listing in #428, namely get test_decorators and test_style to pass, when currently on lama-to-dask they fail, by making a few obvious tweaks.
sadielbartholomew added 2 commits
November 22, 2022 02:19
sadielbartholomew
added
testing
labels
Nov 22, 2022
sadielbartholomew
added this to the
3.14.0 milestone
sadielbartholomew
requested a review
from davidhassell
sadielbartholomew
self-assigned this
sadielbartholomew
mentioned this pull request
davidhassell approved these changes Nov 22, 2022
Copy link Copy Markdown
Collaborator
davidhassell
left a comment
davidhassell
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, thanks. Please merge when you're ready.
sadielbartholomew
merged commit
090811f
into
NCAS-CMS:lama-to-dask
sadielbartholomew
deleted the
lama-to-dask-test-suite-decorators
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment