In `cf.read`, skip caching elements from compression index variables. by davidhassell · Pull Request #671 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 2 commits intoNCAS-CMS:mainfrom
Jun 20, 2023Merged
In cf.read, skip caching elements from compression index variables.#671
davidhassell merged 2 commits intoNCAS-CMS:mainfrom
In cf.read, skip caching elements from compression index variables.#671
davidhassell merged 2 commits intoNCAS-CMS:mainfrom
Conversation
Copy link Copy Markdown
Collaborator
Requires cfdm 1.10.1.1, specifically NCAS-CMS/cfdm#260 (Edit 2023-06-20: now merged into main), from which it utilises the new compression_index keyword parameter of NetCDF._create_data.
davidhassell
added this to the
Next release milestone
davidhassell
requested a review
from sadielbartholomew
sadielbartholomew approved these changes Jun 19, 2023
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but works and incorporates the speedup successfully. Please merge when ready.
cf/read_write/netcdf/netcdfread.py
Outdated
Show resolved
Hide resolved
cf/read_write/netcdf/netcdfread.py Outdated Show resolved Hide resolved
davidhassell
merged commit
9f676f5
into
NCAS-CMS:main
davidhassell
deleted the
cache-compressed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment