Improve `cf.Field.__getitem__` performance by not re-calculating axis cyclicity by davidhassell · Pull Request #745 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
davidhassell merged 3 commits intoNCAS-CMS:mainfrom
Mar 23, 2024Merged
Conversation
davidhassell
requested a review
from sadielbartholomew
sadielbartholomew approved these changes Mar 22, 2024
Copy link Copy Markdown
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, and well-motivated. I've raised some minor comments but please merge once you've considered those.
cf/mixin/fielddomain.py
Show resolved
Hide resolved
cf/mixin/fielddomain.py Show resolved Hide resolved
cf/mixin/fielddomain.py
Outdated
Show resolved
Hide resolved
cf/mixin/fielddomain.py Outdated Show resolved Hide resolved
cf/field.py
Outdated
Show resolved
Hide resolved
cf/field.py
Outdated
Show resolved
Hide resolved
cf/field.py
Outdated
Show resolved
Hide resolved
davidhassell and others added 2 commits
March 23, 2024 18:50Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
davidhassell
merged commit
c02a935
into
NCAS-CMS:main
davidhassell
deleted the
getitem-cyclic
branch
sadielbartholomew
mentioned this pull request
davidhassell
added this to the
3.16.2 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment