Prevent Field subspace `ValueError` from cyclicity check by sadielbartholomew · Pull Request #757 · NCAS-CMS/cf-python
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 23
Closed
sadielbartholomew wants to merge 1 commit intoNCAS-CMS:mainfrom
Closed
Prevent Field subspace ValueError from cyclicity check#757
sadielbartholomew wants to merge 1 commit intoNCAS-CMS:mainfrom
Prevent Field subspace ValueError from cyclicity check#757
sadielbartholomew wants to merge 1 commit intoNCAS-CMS:mainfrom
Conversation
Copy link Copy Markdown
Member
sadielbartholomew
self-assigned this
sadielbartholomew
mentioned this pull request
sadielbartholomew
marked this pull request as ready for review
sadielbartholomew
mentioned this pull request
sadielbartholomew
requested a review
from davidhassell
Copy link Copy Markdown
Member Author
sadielbartholomew
commented
Apr 19, 2024
sadielbartholomew commented
Apr 19, 2024Closing since we've decided that this isn't needed with a fix to the underlying issue, #758, and in fact would hide bugs similar to that one should they occur in future. I am opening a PR to fix that one shortly.
sadielbartholomew
closed this
sadielbartholomew
deleted the
cyclicity-processing-fix
branch
sadielbartholomew
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant