Only display the overlays for nodes that are in the viewer render path and have their properties panel maximized by devernay · Pull Request #745

Only display the overlays for nodes that are in the viewer render path and have their properties panel maximized by devernay · Pull Request #745 · NatronGitHub/Natron

…h and have their properties panel maximized

fixes #744

mentioned this pull request

Jan 8, 2022

7 tasks

devernay added a commit that referenced this pull request

Jan 11, 2022

- addresses issue commented in #745 (review)
- when panel maximized, buttons are displayed even if viewer is not in render path (see #744 for an explanation of that feature). This is not 100% satisfcatory, but better than before IMHO
- minimized() and maximized() were originally two separate signals (in NodeSettingsPanel), so I kept it that way, but we could have simpler definitions of NodeGui::onSettingsPanelMinimized() and NodeGui::onSettingsPanelMaximized() that simply call NodeGui::onSettingsPanelClosed(true) or NodeGui::onSettingsPanelClosed(false).

devernay added a commit that referenced this pull request

Jan 11, 2022

…748)

- addresses issue commented in [#745 (review)](#745 (review))
- when panel is maximized, buttons are displayed even if viewer is not in render path (see #744 for an explanation of that feature). This is not 100% satisfactory, but better than before IMHO
- do not show the viewer buttons if a node is selected in the nodegraph but has its properties panel minimized
- maximize properties panel when double-clicking a node in the nodegraph
- minimized() and maximized() were originally two separate signals (in NodeSettingsPanel), so I kept it that way, but we could have simpler definitions of NodeGui::onSettingsPanelMinimized() and NodeGui::onSettingsPanelMaximized() that simply call NodeGui::onSettingsPanelClosed(true) or NodeGui::onSettingsPanelClosed(false).