PHP 5.4: New `PHPCompatibility.ParameterValues.NewNumberFormatMultibyteSeparators` sniff by jrfnl · Pull Request #1139 · PHPCompatibility/PHPCompatibility
Navigation Menu
{{ message }}
PHPCompatibility / PHPCompatibility Public
- Notifications You must be signed in to change notification settings
- Fork 204
Merged
Jul 11, 2020Conversation
Copy link Copy Markdown
Member
jrfnl
commented
Jun 29, 2020
jrfnl
commented
From: https://www.php.net/manual/en/function.number-format.php#refsect1-function.number-format-changelog
This function now supports multiple bytes in
dec_pointandthousands_sep. Only the first byte of each separator was used in older versions.
This sniff addresses that change.
Includes unit tests.
…byteSeparators` sniff From: https://www.php.net/manual/en/function.number-format.php#refsect1-function.number-format-changelog > This function now supports multiple bytes in `dec_point` and `thousands_sep`. Only the first byte of each separator was used in older versions. This sniff addresses that change. Includes unit tests.
jrfnl
added
Type: enhancement
PR: ready for review
labels
jrfnl
added this to the
10.0.0 milestone
jrfnl
requested a review
from wimg
wimg approved these changes Jul 11, 2020
wimg
merged commit
03fc45e
into
develop
wimg
deleted the
feature/new-newnumberformatmultibyteseparators-sniff
branch
jrfnl
removed
the
PR: ready for review
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment