PHP 8.0: New `PHPCompatibility.ParameterValues.RemovedGetDefinedFunctionsExcludeDisabledFalse` sniff by jrfnl · Pull Request #1150 · PHPCompatibility/PHPCompatibility
Navigation Menu
{{ message }}
PHPCompatibility / PHPCompatibility Public
- Notifications You must be signed in to change notification settings
- Fork 204
Merged
Conversation
Copy link Copy Markdown
Member
Calling
get_defined_functions()with$exclude_disabledexplicitly set to
falseis deprecated.get_defined_functions()will never include disabled functions.
Refs:
- https://github.com/php/php-src/blob/69888c3ff1f2301ead8e37b23ff8481d475e29d2/UPGRADING#L514-L516
- Completely remove disabled functions from function table php/php-src#5473
- php/php-src@53eee29
This sniff addresses that change.
Includes unit tests.
Related to #809
…ctionsExcludeDisabledFalse` sniff > Calling `get_defined_functions()` with `$exclude_disabled` explicitly set to > `false` is deprecated. `get_defined_functions()` will never include disabled functions. Refs: * https://github.com/php/php-src/blob/69888c3ff1f2301ead8e37b23ff8481d475e29d2/UPGRADING#L514-L516 * php/php-src#5473 * php/php-src@53eee29 This sniff addresses that change. Includes unit tests.
jrfnl
added
Type: enhancement
PR: ready for review
labels
jrfnl
added this to the
10.0.0 milestone
jrfnl
requested a review
from wimg
wimg approved these changes Jul 11, 2020
wimg
merged commit
ca38484
into
develop
wimg
deleted the
php-8.0/new-removedgetdefinedfunctionsexcludedisabledfalse-sniff
branch
jrfnl
mentioned this pull request
jrfnl
removed
the
PR: ready for review
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment