PHP 8.0: New `PHPCompatibility.ParameterValues.RemovedSplAutoloadRegisterThrowFalse` sniff by jrfnl · Pull Request #1181 · PHPCompatibility/PHPCompatibility
| * | ||
| * @since 10.0.0 | ||
| */ | ||
| class RemovedSplAutoloadRegisterThrowFalseSniff extends AbstractFunctionCallParameterSniff |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The classname makes it seem as if it throws false ?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a suggestion for a better name which still aligns with the naming scheme of these type of ParameterValue sniffs ?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky one... RemovedSplAutoloadRegisterThrowEqualsFalseSniff ?
wimg approved these changes Aug 18, 2020
| * | ||
| * @since 10.0.0 | ||
| */ | ||
| class RemovedSplAutoloadRegisterThrowFalseSniff extends AbstractFunctionCallParameterSniff |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky one... RemovedSplAutoloadRegisterThrowEqualsFalseSniff ?
wimg
deleted the
PHP-8.0/new-removedsplautoloadregisterthrowfalse-sniff
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters