PHP 8.0: NewIniDirectives: account for configurable string length in getTraceAsString() by jrfnl · Pull Request #1191 · PHPCompatibility/PHPCompatibility

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jrfnl

Copy link Copy Markdown

Member

@jrfnl jrfnl commented

Jul 30, 2020

edited

Loading

  • zend.exception_string_param_max_len
    . New INI directive to set the maximum string length in an argument of a
    stringified stack strace.

Refs:

Includes unit tests.

Related to #809

…getTraceAsString()

> - zend.exception_string_param_max_len
>   . New INI directive to set the maximum string length in an argument of a
>   stringified stack strace.

Refs:
* https://wiki.php.net/rfc/throwable_string_param_max_len
* https://github.com/php/php-src/blob/47e4001976f3ff85a6d479df39dc82d4ceb18b19/UPGRADING#L957-L959
* php/php-src#5769
* php/php-src@07db641

Includes unit tests.

@jrfnl jrfnl added Type: enhancement PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Jul 30, 2020

@jrfnl jrfnl added this to the 10.0.0 milestone

Jul 30, 2020

@jrfnl jrfnl requested a review from wimg

July 30, 2020 18:32

@wimg wimg merged commit 0a105a9 into develop

Aug 9, 2020

@wimg wimg deleted the php-8.0/newinidirectives-gettraceasstring-rfc branch

August 9, 2020 18:44

@jrfnl jrfnl removed PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Aug 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

10.0.0-alpha1

Development

Successfully merging this pull request may close these issues.

2 participants

@jrfnl @wimg