PHP 8.0: NewClasses: handle 3 new classes by jrfnl · Pull Request #1211 · PHPCompatibility/PHPCompatibility
Navigation Menu
{{ message }}
PHPCompatibility / PHPCompatibility Public
- Notifications You must be signed in to change notification settings
- Fork 204
Merged
PHP 8.0: NewClasses: handle 3 new classes#1211
PHP 8.0: NewClasses: handle 3 new classes#1211
Conversation
Copy link Copy Markdown
Member
jrfnl
commented
Aug 17, 2020
jrfnl
commented
The commits in this PR line up with the commits in PHP Core to add the classes.
Related to #809
PHP 8.0: NewClasses: account for new WeakMap class
Added WeakMap.
Refs:
PHP 8.0: NewClasses: account for new PhpToken class
The new PhpToken class adds an object-based interface to the tokenizer.
It provides a more uniform and ergonomic representation, while being more
memory efficient and faster.
Refs:
- https://wiki.php.net/rfc/token_as_object
- https://github.com/php/php-src/blob/4522cbb789ea4d0b70b5a1bdf7f3c0f4648d8fb7/UPGRADING#L929-L933
- Implement object-based token_get_all() alternative php/php-src#5176
- php/php-src@5a09b9f
PHP 8.0: NewClasses: account for new ValueError exception class
Added ValueError class.
Refs:
jrfnl added 3 commits
August 17, 2020 02:01> Added WeakMap. Refs: * https://wiki.php.net/rfc/weak_maps * php/php-src#4882 * php/php-src@d8c9902
> The new PhpToken class adds an object-based interface to the tokenizer. > It provides a more uniform and ergonomic representation, while being more memory efficient and faster. Refs: * https://wiki.php.net/rfc/token_as_object * https://github.com/php/php-src/blob/4522cbb789ea4d0b70b5a1bdf7f3c0f4648d8fb7/UPGRADING#L929-L933 * php/php-src#5176 * php/php-src@5a09b9f
> Added ValueError class. Refs: * https://github.com/php/php-src/blob/master/UPGRADING#L639 * php/php-src@bc61997
jrfnl
added
Type: enhancement
PR: quick merge
PR: ready for review labels
Aug 17, 2020
jrfnl
added this to the
10.0.0 milestone
jrfnl
requested a review
from wimg
jrfnl
mentioned this pull request
40 tasks
wimg approved these changes Aug 18, 2020
wimg
merged commit
b6f9b08
into
develop
wimg
deleted the
php-8.0/newclasses-x3
branch
jrfnl
removed
PR: quick merge
PR: ready for review labels
Aug 18, 2020This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment