PHP 8.0: NewClasses: add yet more new classes by jrfnl · Pull Request #1246 · PHPCompatibility/PHPCompatibility
added 3 commits
December 2, 2020 16:09> The OCI-Lob class is now called OCILob, and the OCI-Collection class is now > called OCICollection for name compliance enforced by PHP 8 arginfo > type annotation tooling. This commit: * Adds the new classes to the `NewClasses` sniff. * Updated the `alternative`s for various deprecated/removed functions in the `RemovedFunctions` sniff. Based on the commit, it looks like the _old_ classnames are removed without deprecation. Making a note of this in the `RemovedClasses` sniff, but not enabling the check as the places where we are searching for the name, do not allow for the old name in the first place - would have been a parse error. Also see: https://bugs.php.net/bug.php?id=79625 Refs: * https://github.com/php/php-src/blob/0a84fba0deb1c1b75770a436c4236dc56e6d0463/UPGRADING#L392-L394 * php/php-src@ff66e49
wimg approved these changes Dec 4, 2020
wimg
deleted the
php-8.0/more-new-removed-classes
branch
jrfnl
mentioned this pull request
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters