QA: consistency of error types and codes by jrfnl · Pull Request #1282 · PHPCompatibility/PHPCompatibility

@jrfnl

As per 1163:
* Deprecations should throw warnings.
* Removals should throw errors.
* Both should use a different error code.

Note: the `RemovedAssertStringAssertion` sniff is new to PHPCompatibility 10.0.0, so this error code change has no consequences.
The error code change for the `RemovedTernaryAssociativity` should be noted in the changelog though as the sniff was introduced in PHPCompatibility 9.2.0.

Fixes 1163

wimg

wimg approved these changes Apr 17, 2021

@wimg wimg deleted the feature/1163-message-type-code-review branch

April 17, 2021 15:19

@jrfnl jrfnl mentioned this pull request

Sep 8, 2021