Numbers/RemovedHexadecimalNumericStrings: prevent some false positives by jrfnl · Pull Request #1366 · PHPCompatibility/PHPCompatibility
jrfnl
mentioned this pull request
1 task
wimg approved these changes Oct 27, 2022
Apparently, hexadecimal numeric strings are still supported in a limited number of PHP functions. While if they are passed in as a variable, we're out of luck, if the text string is hard-coded in the function call, we can prevent a false positive. This commit adds the logic necessary to prevent these false positives for a limited set of functions currently known to still support hexadecimal numeric strings. Note: The logic takes function calls using PHP 8.0 named parameters into account. Includes unit tests. Fixes 1345
jrfnl
deleted the
feature/1345-validintegers-prevent-false-positive
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters