PHP 8.4 | :sparkles: New PHPCompatibility.Classes.ForbiddenClassNameUnderscore sniff (RFC) by jrfnl · Pull Request #1742 · PHPCompatibility/PHPCompatibility
Navigation Menu
{{ message }}
PHPCompatibility / PHPCompatibility Public
- Notifications You must be signed in to change notification settings
- Fork 204
Merged
Conversation
Copy link Copy Markdown
Member
. Using "_" as a class name is now deprecated.
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_using_a_single_underscore_as_a_class_name
This commit introduces a new sniff to detect and flag this.
Includes tests.
Includes documentation.
Refs:
- https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_using_a_single_underscore_as_a_class_name
- https://github.com/php/php-src/blob/81150187fb91b38e9437b12bfff467607c458c14/UPGRADING#L417-L418
- Deprecate using "_" as a class name php/php-src#15360
- php/php-src@0a23b06
Related to #1731
… sniff (RFC) > . Using "_" as a class name is now deprecated. > RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_using_a_single_underscore_as_a_class_name This commit introduces a new sniff to detect and flag this. Includes tests. Includes documentation. Refs: * https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_using_a_single_underscore_as_a_class_name * https://github.com/php/php-src/blob/81150187fb91b38e9437b12bfff467607c458c14/UPGRADING#L417-L418 * php/php-src 15360 * php/php-src@0a23b06 Related to 1731 VERIFIED
jrfnl
added
Type: enhancement
PR: ready for review
labels
jrfnl
added this to the
10.0.0 milestone
jrfnl
requested a review
from wimg
This was referenced
Aug 14, 2024wimg approved these changes Aug 31, 2024
wimg
merged commit
e2d8da9
into
develop
wimg
deleted the
php-8.4/new-forbiddenclassname-sniff
branch
github-actions
bot
removed
the
PR: ready for review
label
jrfnl
added
the
PHP: 8.4
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment