Composer: update recommended Composer PHPCS installer version by jrfnl · Pull Request #791

Composer: update recommended Composer PHPCS installer version by jrfnl · Pull Request #791 · PHPCompatibility/PHPCompatibility

Merged

wimg merged 1 commit intomasterfrom

feature/update-phpcs-plugin-version

Mar 11, 2019

Merged

Composer: update recommended Composer PHPCS installer version#791
wimg merged 1 commit intomasterfrom
feature/update-phpcs-plugin-version

Conversation

Copy link Copy Markdown

Member

jrfnl commented
Feb 20, 2019

Composer treats minors before 1.0.0 as majors. As the DealerDirect plugin has released version 0.5.0 a while back, we should recommend for people to use the latest version instead.

Refs:

jrfnl added Type: chores/QA PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Feb 20, 2019

jrfnl added this to the 9.x Next milestone

Feb 20, 2019

jrfnl requested a review from wimg

February 20, 2019 19:03

Copy link Copy Markdown

Member Author

jrfnl commented
Feb 20, 2019

Note: the builds failing is as expected. PR #790 is open to fix that.

jrfnl changed the title ~~Composer: update recommended Composer PHPCS installed version~~ Composer: update recommended Composer PHPCS installer version

Feb 25, 2019

jrfnl force-pushed the feature/update-phpcs-plugin-version branch from c04d783 to d5ea701 Compare

February 25, 2019 22:08

Composer: update recommended Composer PHPCS installed version

b62968d

Composer treats minors before 1.0.0 as majors. As the DealerDirect plugin has released version 0.5.0 a while back, we should recommend for people to use the latest version instead.

Refs:
* https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.5.0
* https://getcomposer.org/doc/articles/versions.md#caret-version-range-

jrfnl force-pushed the feature/update-phpcs-plugin-version branch from d5ea701 to b62968d Compare

March 11, 2019 01:01