NewTypedProperties: add some additional unit tests by jrfnl · Pull Request #829 · PHPCompatibility/PHPCompatibility
Navigation Menu
{{ message }}
PHPCompatibility / PHPCompatibility Public
- Notifications You must be signed in to change notification settings
- Fork 204
Conversation
jrfnl
added
Type: chores/QA
PR: quick merge
PR: ready for review labels
Jun 26, 2019
jrfnl
added this to the
9.2.0 milestone
jrfnl
requested a review
from wimg
Copy link Copy Markdown
Member Author
jrfnl
commented
Jun 26, 2019
jrfnl commented
Jun 26, 2019I have no clue how adding additional unit tests which pass, without touching the code being tested, could ever decrease the test coverage... 😲
wimg approved these changes Jun 26, 2019
Copy link Copy Markdown
Member
wimg
commented
Jun 26, 2019
wimg commented
Jun 26, 2019Strange that coveralls report lower coverage?
Copy link Copy Markdown
Member Author
jrfnl
commented
Jun 26, 2019
jrfnl commented
Jun 26, 2019@wimg I could try to rebase the PR on the current master to see if that makes a difference ? (i.e. whether it was just a temporary hickup in Coveralls)
jrfnl
force-pushed
the
feature/newtypedproperties-tweak-unittests
branch
from
e5d3736 to
745b598
Compare
Copy link Copy Markdown
Member Author
Ok, so it looks like it was a Coveralls hickup as code coverage now looks to have improved by 0.6%..... (or rather is the same between the branch and the PR - which it should always be anyway, but you IT is hard.... hmm... on that note: maybe I should adjust the travis script to disable the Coveralls check when not on master or in a PR branch ?)
wimg
merged commit
fd781d5
into
master
delete-merged-branch
bot
deleted the
feature/newtypedproperties-tweak-unittests
branch
jrfnl
mentioned this pull request
jrfnl
removed
PR: ready for review
PR: quick merge
labels
Sep 5, 2019This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment