PHP 7.0/7.4: handle removed & re-introduced tokenizer constant(s) by jrfnl · Pull Request #882 · PHPCompatibility/PHPCompatibility

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jrfnl

Copy link Copy Markdown

Member

@jrfnl jrfnl commented

Aug 26, 2019

edited

Loading

PHP 7.0/RemovedConstants: handle removed tokenizer constants

Ref:

PHP 7.4/NewConstants: handle new T_BAD_CHARACTER token

Tokenizer:
token_get_all() will now emit a T_BAD_CHARACTER token for unexpected
characters instead of leaving behind holes in the token stream.

Refs:

Related to #808

panvid reacted with thumbs up emoji

@jrfnl jrfnl added Type: enhancement PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Aug 26, 2019

@jrfnl jrfnl added this to the 9.3.0 milestone

Aug 26, 2019

@jrfnl jrfnl requested a review from wimg

August 26, 2019 19:23

@jrfnl jrfnl changed the title PHP 7.0/7.4: handle removed & re-introduced tokenizes constant(s) PHP 7.0/7.4: handle removed & re-introduced tokenizer constant(s)

Aug 26, 2019

@wimg wimg merged commit ab8b218 into master

Aug 28, 2019

@delete-merged-branch delete-merged-branch bot deleted the feature/removed-new-tokenizer-constants branch

August 28, 2019 14:06

@jrfnl jrfnl removed PR: ready for review PR: quick merge

PR only contains relatively simple changes

labels

Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

9.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jrfnl @wimg