PHP 7.4/NewConstants: more new PHP 7.4 constants by jrfnl · Pull Request #887 · PHPCompatibility/PHPCompatibility

Conversation

@jrfnl

Copy link Copy Markdown

Member

@jrfnl jrfnl commented

Aug 28, 2019

edited

Loading

PHP 7.4/NewConstants: handle new IMG_FILTER_SCATTER

  • GD:
    Added the "scatter" image filter (IMG_FILTER_SCATTER) to apply a scatter
    filter to images. This filter has the following prototype:

imagefilter($im, IMG_FILTER_SCATTER, int $sub, int $plus, array $colors = []);

Refs:

PHP 7.4/NewConstants: handle new PASSWORD_ARGON2_PROVIDER

From the RFC:

New Constants

Just in case an application wants to know where their argon2 support is coming from, I'd propose a new constant to be declared by whichever module is providing the support.

PASSWORD_ARGON2_PROVIDER == 'standard' || 'sodium'

Refs:

Related to #808

jrfnl added 2 commits

August 28, 2019 16:50
> - GD:
>    Added the "scatter" image filter (IMG_FILTER_SCATTER) to apply a scatter
>    filter to images. This filter has the following prototype:
>
> imagefilter($im, IMG_FILTER_SCATTER, int $sub, int $plus, array $colors = []);

Refs:
* https://github.com/php/php-src/blob/3775d47eee38f3b34f800a0b23f840ec7a94e4c7/UPGRADING#L247-L256
* php/php-src@bcd11a1
From the RFC:
> New Constants
>
> Just in case an application wants to know where their argon2 support is coming from, I'd propose a new constant to be declared by whichever module is providing the support.
>
> PASSWORD_ARGON2_PROVIDER == 'standard' || 'sodium'

Refs:
* https://wiki.php.net/rfc/sodium.argon.hash
* php/php-src#4012
* php/php-src@0ba1db7

@jrfnl jrfnl added Type: enhancement PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Aug 28, 2019

@jrfnl jrfnl added this to the 9.3.0 milestone

Aug 28, 2019

@jrfnl jrfnl requested a review from wimg

August 28, 2019 14:54

@wimg wimg merged commit c939f96 into master

Aug 28, 2019

@delete-merged-branch delete-merged-branch bot deleted the php-7.4/newconstants-more-new-constants branch

August 28, 2019 14:56

@jrfnl jrfnl removed PR: ready for review PR: quick merge

PR only contains relatively simple changes

labels

Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

9.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jrfnl @wimg