Updated contribution documentation + Removed WPEngine logo by wimg · Pull Request #904 · PHPCompatibility/PHPCompatibility

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@wimg

  • Updated contribution documentation to reflect change from master to develop
  • Removed WPEngine logo (wasn't working anymore). Kept link.

jrfnl

@jrfnl jrfnl left a comment

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm wondering if we may need to update the links for some of the badges in the Readme too to point explicitly to develop or master ?
  • Regarding projects using PHPCompatibility: I'm wondering if we should limit this to projects which function like a shell around PHPCompatibility, like the first three listed.
    Listing external PHPCS standards which just use PHPCompatibility as part of their internal process / require-dev seems like it may become a long, arbitrary and unmanageable list.

More external projects / shells:

@wimg

  • I'm wondering if we may need to update the links for some of the badges in the Readme too to point explicitly to develop or master ?

Changed that. Consistency is indeed key there.

  • Regarding projects using PHPCompatibility: I'm wondering if we should limit this to projects which function like a shell around PHPCompatibility, like the first three listed.

Updated it.

jrfnl

@jrfnl

Labels

2 participants

@wimg @jrfnl