RequiredToOptionalFunctionParameters: bug fix for class instantiation by jrfnl · Pull Request #914 · PHPCompatibility/PHPCompatibility

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jrfnl

Copy link Copy Markdown

Member

@jrfnl jrfnl commented

Sep 30, 2019

Prevent recognizing class instantiation as if it were a function call.

Includes unit test.

Fixes #913

Prevent recognizing class instantiation as if it were a function call.

Includes unit test.

Fixes 913

@jrfnl jrfnl added Type: bug PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Sep 30, 2019

@jrfnl jrfnl added this to the 9.x Next milestone

Sep 30, 2019

@jrfnl jrfnl requested a review from wimg

September 30, 2019 11:01

@wimg wimg merged commit 2db9d9c into develop

Oct 16, 2019

@wimg wimg deleted the feature/913-optional-to-required-params-bugfix branch

October 16, 2019 16:46

@jrfnl jrfnl removed PR: ready for review PR: quick merge

PR only contains relatively simple changes

labels

Oct 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

9.3.2

Development

Successfully merging this pull request may close these issues.

False positive on user class named Crypt

2 participants

@jrfnl @wimg