NewConstants: account for SODIUM_CRYPTO_PWHASH_ALG_ARGON2ID13 by jrfnl · Pull Request #915 · PHPCompatibility/PHPCompatibility

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jrfnl

Copy link Copy Markdown

Member

@jrfnl jrfnl commented

Oct 1, 2019

Looks like this constant has been in PHP since 7.2, but was previously missed.
The constant might not have been listed in the documentation until recently.

Ref:

Looks like this constant has been in PHP since 7.2, but was previously missed.
The constant might not have been listed in the documentation until recently.

Ref:
* php/php-src@613c8dd

@jrfnl jrfnl added Type: enhancement PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Oct 1, 2019

@jrfnl jrfnl added this to the 9.x Next milestone

Oct 1, 2019

@jrfnl jrfnl requested a review from wimg

October 1, 2019 22:07

@wimg wimg merged commit 02f7503 into develop

Oct 2, 2019

@wimg wimg deleted the feature/new-constants-add-another-sodium-constant branch

October 2, 2019 11:44

@jrfnl jrfnl removed PR: quick merge

PR only contains relatively simple changes

PR: ready for review labels

Oct 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

9.3.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jrfnl @wimg