Add suppression of warning for MS policy by JamesWTruher · Pull Request #1205 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
JamesWTruher merged 1 commit intoPowerShell:developmentfrom
Apr 2, 2019Merged
Add suppression of warning for MS policy#1205
JamesWTruher merged 1 commit intoPowerShell:developmentfrom
Add suppression of warning for MS policy#1205
JamesWTruher merged 1 commit intoPowerShell:developmentfrom
Conversation
Copy link
Contributor
JamesWTruher
commented
Apr 2, 2019
JamesWTruher
commented
Because we are using a direct invocation of ConvertTo-SecureString it triggers a warning by MS tools that secrets are not allowed to be checked in to our repository. This suppresses this warning.
PR Summary
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Because we are using a direct invocation of ConvertTo-SecureString it triggers a warning by MS tools that secrets are not allowed to be checked in to our repository. This suppresses this warning.
JamesWTruher
self-assigned this
JamesWTruher
requested a review
from TravisEz13
TravisEz13 approved these changes Apr 2, 2019
JamesWTruher
merged commit
c7e9e5c
into
PowerShell:development
JamesWTruher
deleted the
suppressWarning001
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment