Update Newtonsoft json to 12.0.1 due to PowerShell 6.1 going out of support by bergmeister · Pull Request #1336 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
JamesWTruher merged 3 commits intoPowerShell:masterfrom
Sep 12, 2019Merged
Conversation
Copy link
Collaborator
bergmeister
commented
Sep 12, 2019
bergmeister
commented
PR Summary
This implicitly ups the minimum requirement for PS Core to 6.2.0 (because PowerShell cannot load a newer version of Newtonsoft than the version that it ships with). This is OK because PS 6.1 will go out of support in a week anyway.
I had to change the AppVeyor image to a newer one to get PS 6.2.0. If that AppVeyor had a newer patch of 6.2 then we could've even upgraded to Newtonsoft 12.0.2 (PowerShell 6.2.1 started shipping with this patch)
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister added 3 commits
September 11, 2019 19:20
bergmeister
added
Area - Build
Breaking Change
labels
bergmeister
requested review from
JamesWTruher and
rjmholt
JamesWTruher approved these changes Sep 12, 2019
JamesWTruher approved these changes Sep 12, 2019
JamesWTruher
merged commit
b9fd7b3
into
PowerShell:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment