Update Newtonsoft json to 12.0.1 due to PowerShell 6.1 going out of support by bergmeister · Pull Request #1336 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bergmeister

Copy link

Collaborator

PR Summary

This implicitly ups the minimum requirement for PS Core to 6.2.0 (because PowerShell cannot load a newer version of Newtonsoft than the version that it ships with). This is OK because PS 6.1 will go out of support in a week anyway.
I had to change the AppVeyor image to a newer one to get PS 6.2.0. If that AppVeyor had a newer patch of 6.2 then we could've even upgraded to Newtonsoft 12.0.2 (PowerShell 6.2.1 started shipping with this patch)

PR Checklist

@JamesWTruher JamesWTruher merged commit b9fd7b3 into PowerShell:master

Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmholt rjmholt Awaiting requested review from rjmholt

1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergmeister @JamesWTruher